Conversation
Contributor
|
Closing because the destination doesn't exist: Happy to take it the moment there's something at that path — the command itself is two lines and fine. If the keypad page is still planned, this is worth reopening alongside it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the macro keyboard tries to execute the command
keypadon the root.vc site because it is formatted as a command instead of a path.Because it seems unlikely that the hardware itself will be updated on already sent devices, a command is added in this PR to make sure this still opens the URL correctly.
Alternatively / along with, a PR is created on the
macro_keyboardrepository to update the URL so that this change is not required in the future and links directly.See: rootvc/macro_keyboard#1